Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set rln message limit to 100 #106

Merged
merged 2 commits into from
Jul 16, 2024
Merged

Set rln message limit to 100 #106

merged 2 commits into from
Jul 16, 2024

Conversation

alrevuelta
Copy link
Collaborator

Set rln message limit to 100

@alrevuelta
Set rln message limit to 100
7c95cc4 
Set rln message limit to 100
fryorcraken
fryorcraken approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@fryorcraken fryorcraken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think max limit is fair for nwaku compose as they can provide RLNaaS to light clients (js-waku).

20msg/10min limit should what we encourage to use in application. Most likely once RLN is done in js-waku or status.

@alrevuelta
Copy link
Collaborator Author

Will block this PR from merging until waku-org/nwaku#2883 is included in a release since it is required. Should be either 0.30.2 or 0.31.0.

@alrevuelta
Copy link
Collaborator Author

Not ideal but by now note that rln-relay-user-message-limit provided in generateRlnKeystore is coupled with this parameter taken from TWN network config here. If they don't match things won't work, especially if the former parameter is lower than the later.

In other words, they should match, currently 100 in both places.

Will block this PR from merging until waku-org/nwaku#2883 is included in a release since it is required. Should be either 0.30.2 or 0.31.0.

The release of 0.30.2 unblocked this PR. Ready now.

@gabrielmer gabrielmer merged commit a737ff9 into master Jul 16, 2024
@gabrielmer gabrielmer deleted the msg-limit branch July 16, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ivansete-status Ivansete-status Ivansete-status approved these changes

@fryorcraken fryorcraken fryorcraken approved these changes

Assignees

@alrevuelta alrevuelta

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alrevuelta @fryorcraken @Ivansete-status @gabrielmer